Change in osmo-gsm-tester[master]: iperfserver: adds an offset to the default port.

alealcon gerrit-no-reply at lists.osmocom.org
Tue Jun 1 10:16:01 UTC 2021


alealcon has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24271 )

Change subject: iperfserver: adds an offset to the default port.
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review-1
> 
> I don't really see the point of adding this parameter, it's not really needed, since you can already set the port directly. If you want to count from the default port, then you can easily do something like this:
> srv = IPerf3Server(...)
> srv.set_port(srv.DEFAULT_SRV_PORT + offset)

Cool I will do as you suggest. I modified the constructor because I'm used to define those values in the constructor instead of a setter function.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24271
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I23f0e5ae599825627a23333a0255577bbc013a3c
Gerrit-Change-Number: 24271
Gerrit-PatchSet: 1
Gerrit-Owner: alealcon <alejandro.leal at srs.io>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 01 Jun 2021 10:16:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210601/c74c3a84/attachment.htm>


More information about the gerrit-log mailing list