Change in osmo-bsc[master]: handover dot charts: fix wrong transitions regarding MGW

neels gerrit-no-reply at lists.osmocom.org
Tue Jun 1 17:29:39 UTC 2021


neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24359 )

Change subject: handover dot charts: fix wrong transitions regarding MGW
......................................................................

handover dot charts: fix wrong transitions regarding MGW

Related: SYS#5315 OS#4940 OS#3277
Change-Id: I2ed9b3ca7fe145a930ca509e6b3943f5abf3aa62
---
M doc/handover-inter-bsc-in-fsm.dot
M doc/handover-intra-bsc-fsm.dot
2 files changed, 5 insertions(+), 6 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved



diff --git a/doc/handover-inter-bsc-in-fsm.dot b/doc/handover-inter-bsc-in-fsm.dot
index b52a16d..0c6af85 100644
--- a/doc/handover-inter-bsc-in-fsm.dot
+++ b/doc/handover-inter-bsc-in-fsm.dot
@@ -18,7 +18,10 @@
 	gscon -> HO_ST_WAIT_LCHAN_ACTIVE [label="handover_start_inter_bsc_in()",style=dotted]
 	HO_ST_WAIT_LCHAN_ACTIVE -> lchan [label="lchan_activate()\nFOR_HANDOVER",style=dotted]
 	lchan -> HO_ST_WAIT_LCHAN_ACTIVE [label="HO_EV_\nLCHAN_ACTIVE,\n_ERROR",style=dotted,constraint=false]
-	HO_ST_WAIT_LCHAN_ACTIVE -> HO_ST_WAIT_RR_HO_DETECT
+	HO_ST_WAIT_LCHAN_ACTIVE -> HO_ST_WAIT_RR_HO_DETECT [label="SCCPlite\nor no voice"]
+
+	HO_ST_WAIT_LCHAN_ACTIVE -> WAIT_MGW_ENDPOINT_TO_MSC [label="AoIP\nhas voice"]
+	WAIT_MGW_ENDPOINT_TO_MSC -> HO_ST_WAIT_RR_HO_DETECT
 	
 	HO_ST_WAIT_RR_HO_DETECT -> msc2 [label="BSSMAP\nHandover\nAccept\nwith\nRR Handover\nCommand",style=dotted]
 	msc2 -> old_bsc2 -> old_lchan [label="RR Handover\nCommand",style=dotted]
@@ -31,9 +34,7 @@
 	WAIT_RR_HO_COMPLETE -> WAIT_LCHAN_ESTABLISHED
 	lchan -> WAIT_LCHAN_ESTABLISHED [label="HO_EV_LCHAN_\nESTABLISHED",style=dotted]
 
-	WAIT_LCHAN_ESTABLISHED -> terminate [label="non-TCH"]
-	WAIT_LCHAN_ESTABLISHED -> WAIT_MGW_ENDPOINT_TO_MSC
-	WAIT_MGW_ENDPOINT_TO_MSC -> terminate [label="handover_end()"]
+	WAIT_LCHAN_ESTABLISHED -> terminate
 	terminate -> msc2 [label="BSSMAP Handover\nComplete\n/ Failure",style=dotted,constraint=false]
 
 	err [label="on error",shape=box,style=dashed]
diff --git a/doc/handover-intra-bsc-fsm.dot b/doc/handover-intra-bsc-fsm.dot
index 53b3eed..39f3097 100644
--- a/doc/handover-intra-bsc-fsm.dot
+++ b/doc/handover-intra-bsc-fsm.dot
@@ -25,6 +25,4 @@
 	lchan -> WAIT_LCHAN_ESTABLISHED [label="HO_EV_LCHAN_\nESTABLISHED",style=dotted]
 
 	WAIT_LCHAN_ESTABLISHED -> terminate [label="non-TCH"]
-	WAIT_LCHAN_ESTABLISHED -> WAIT_MGW_ENDPOINT_TO_MSC
-	WAIT_MGW_ENDPOINT_TO_MSC -> terminate [label="handover_end()"]
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24359
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I2ed9b3ca7fe145a930ca509e6b3943f5abf3aa62
Gerrit-Change-Number: 24359
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210601/5ec010d5/attachment.htm>


More information about the gerrit-log mailing list