<p>neels <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24359">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">handover dot charts: fix wrong transitions regarding MGW<br><br>Related: SYS#5315 OS#4940 OS#3277<br>Change-Id: I2ed9b3ca7fe145a930ca509e6b3943f5abf3aa62<br>---<br>M doc/handover-inter-bsc-in-fsm.dot<br>M doc/handover-intra-bsc-fsm.dot<br>2 files changed, 5 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/doc/handover-inter-bsc-in-fsm.dot b/doc/handover-inter-bsc-in-fsm.dot</span><br><span>index b52a16d..0c6af85 100644</span><br><span>--- a/doc/handover-inter-bsc-in-fsm.dot</span><br><span>+++ b/doc/handover-inter-bsc-in-fsm.dot</span><br><span>@@ -18,7 +18,10 @@</span><br><span>     gscon -> HO_ST_WAIT_LCHAN_ACTIVE [label="handover_start_inter_bsc_in()",style=dotted]</span><br><span>   HO_ST_WAIT_LCHAN_ACTIVE -> lchan [label="lchan_activate()\nFOR_HANDOVER",style=dotted]</span><br><span>  lchan -> HO_ST_WAIT_LCHAN_ACTIVE [label="HO_EV_\nLCHAN_ACTIVE,\n_ERROR",style=dotted,constraint=false]</span><br><span style="color: hsl(0, 100%, 40%);">-     HO_ST_WAIT_LCHAN_ACTIVE -> HO_ST_WAIT_RR_HO_DETECT</span><br><span style="color: hsl(120, 100%, 40%);">+ HO_ST_WAIT_LCHAN_ACTIVE -> HO_ST_WAIT_RR_HO_DETECT [label="SCCPlite\nor no voice"]</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+     HO_ST_WAIT_LCHAN_ACTIVE -> WAIT_MGW_ENDPOINT_TO_MSC [label="AoIP\nhas voice"]</span><br><span style="color: hsl(120, 100%, 40%);">+    WAIT_MGW_ENDPOINT_TO_MSC -> HO_ST_WAIT_RR_HO_DETECT</span><br><span>       </span><br><span>     HO_ST_WAIT_RR_HO_DETECT -> msc2 [label="BSSMAP\nHandover\nAccept\nwith\nRR Handover\nCommand",style=dotted]</span><br><span>     msc2 -> old_bsc2 -> old_lchan [label="RR Handover\nCommand",style=dotted]</span><br><span>@@ -31,9 +34,7 @@</span><br><span>        WAIT_RR_HO_COMPLETE -> WAIT_LCHAN_ESTABLISHED</span><br><span>     lchan -> WAIT_LCHAN_ESTABLISHED [label="HO_EV_LCHAN_\nESTABLISHED",style=dotted]</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       WAIT_LCHAN_ESTABLISHED -> terminate [label="non-TCH"]</span><br><span style="color: hsl(0, 100%, 40%);">-      WAIT_LCHAN_ESTABLISHED -> WAIT_MGW_ENDPOINT_TO_MSC</span><br><span style="color: hsl(0, 100%, 40%);">-   WAIT_MGW_ENDPOINT_TO_MSC -> terminate [label="handover_end()"]</span><br><span style="color: hsl(120, 100%, 40%);">+   WAIT_LCHAN_ESTABLISHED -> terminate</span><br><span>       terminate -> msc2 [label="BSSMAP Handover\nComplete\n/ Failure",style=dotted,constraint=false]</span><br><span> </span><br><span>      err [label="on error",shape=box,style=dashed]</span><br><span>diff --git a/doc/handover-intra-bsc-fsm.dot b/doc/handover-intra-bsc-fsm.dot</span><br><span>index 53b3eed..39f3097 100644</span><br><span>--- a/doc/handover-intra-bsc-fsm.dot</span><br><span>+++ b/doc/handover-intra-bsc-fsm.dot</span><br><span>@@ -25,6 +25,4 @@</span><br><span>     lchan -> WAIT_LCHAN_ESTABLISHED [label="HO_EV_LCHAN_\nESTABLISHED",style=dotted]</span><br><span> </span><br><span>    WAIT_LCHAN_ESTABLISHED -> terminate [label="non-TCH"]</span><br><span style="color: hsl(0, 100%, 40%);">-      WAIT_LCHAN_ESTABLISHED -> WAIT_MGW_ENDPOINT_TO_MSC</span><br><span style="color: hsl(0, 100%, 40%);">-   WAIT_MGW_ENDPOINT_TO_MSC -> terminate [label="handover_end()"]</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24359">change 24359</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/24359"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2ed9b3ca7fe145a930ca509e6b3943f5abf3aa62 </div>
<div style="display:none"> Gerrit-Change-Number: 24359 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>