Change in osmo-sip-connector[master]: SIP re-INVITE: fix media connection change detection

laforge gerrit-no-reply at lists.osmocom.org
Tue Jun 1 12:45:28 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/24487 )

Change subject: SIP re-INVITE: fix media connection change detection
......................................................................

SIP re-INVITE: fix media connection change detection

Use the correct variable in address comparison.
The type cast hid the incompatible type from the compiler.

Change-Id: I701150f22f0eb49fae821996358568d60a385035
---
M src/sip.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  laforge: Looks good to me, approved



diff --git a/src/sip.c b/src/sip.c
index ba9730a..93ae69c 100644
--- a/src/sip.c
+++ b/src/sip.c
@@ -234,7 +234,7 @@
 		     osmo_sockaddr_ntop((struct sockaddr*)&leg->base.addr, ip_addr),
 		     osmo_sockaddr_port((struct sockaddr*)&leg->base.addr));
 		if (osmo_sockaddr_cmp((struct osmo_sockaddr *)&prev_addr,
-				      (struct osmo_sockaddr *)&leg->base)) {
+				      (struct osmo_sockaddr *)&leg->base.addr)) {
 			LOGP(DSIP, LOGL_INFO, "re-INVITE changes media connection.\n");
 			if (other->update_rtp)
 				other->update_rtp(leg->base.call->remote);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/24487
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I701150f22f0eb49fae821996358568d60a385035
Gerrit-Change-Number: 24487
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210601/0e73d2fe/attachment.htm>


More information about the gerrit-log mailing list