<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/24487">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">SIP re-INVITE: fix media connection change detection<br><br>Use the correct variable in address comparison.<br>The type cast hid the incompatible type from the compiler.<br><br>Change-Id: I701150f22f0eb49fae821996358568d60a385035<br>---<br>M src/sip.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/sip.c b/src/sip.c</span><br><span>index ba9730a..93ae69c 100644</span><br><span>--- a/src/sip.c</span><br><span>+++ b/src/sip.c</span><br><span>@@ -234,7 +234,7 @@</span><br><span>                      osmo_sockaddr_ntop((struct sockaddr*)&leg->base.addr, ip_addr),</span><br><span>               osmo_sockaddr_port((struct sockaddr*)&leg->base.addr));</span><br><span>          if (osmo_sockaddr_cmp((struct osmo_sockaddr *)&prev_addr,</span><br><span style="color: hsl(0, 100%, 40%);">-                                 (struct osmo_sockaddr *)&leg->base)) {</span><br><span style="color: hsl(120, 100%, 40%);">+                                 (struct osmo_sockaddr *)&leg->base.addr)) {</span><br><span>                     LOGP(DSIP, LOGL_INFO, "re-INVITE changes media connection.\n");</span><br><span>                    if (other->update_rtp)</span><br><span>                            other->update_rtp(leg->base.call->remote);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/24487">change 24487</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/24487"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sip-connector </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I701150f22f0eb49fae821996358568d60a385035 </div>
<div style="display:none"> Gerrit-Change-Number: 24487 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>