Change in simtrace2[master]: introduce support for new ngff_cardem board
gerrit-no-reply at lists.osmocom.org
Fri Jul 30 09:09:03 UTC 2021
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/25082 )
Change subject: introduce support for new ngff_cardem board
Patch Set 4:
the code is very readable! only found some cosmetics.
PS4, Line 145: default state
PS4, Line 1: /* sysmocom quad-modem sysmoQMOD application code
* not adjusted to ngff_cardem board
* README.txt also doesn't mention the new board yet
PS4, Line 45: printf("\tU\tProceed to USB Initialization\n\r");
'U' not implemented below? same with '@'
Looks like they are not meant to be implemented as part of this patch, so I'd remove them (or comment them out).
PS4, Line 98:
(missing ) )
PS4, Line 50: /* determine if a tiven WWAN led is currently active or not */
tiven -> given
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/25082
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Jul 2021 09:09:03 +0000
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log