Change in simtrace2[master]: WIP: introduce support for new ngff_cardem board

daniel gerrit-no-reply at lists.osmocom.org
Thu Jul 29 17:59:38 UTC 2021


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/24879 )

Change subject: WIP: introduce support for new ngff_cardem board
......................................................................


Patch Set 2:

(4 comments)

https://gerrit.osmocom.org/c/simtrace2/+/24879/2/firmware/libboard/ngff_cardem/include/board.h 
File firmware/libboard/ngff_cardem/include/board.h:

https://gerrit.osmocom.org/c/simtrace2/+/24879/2/firmware/libboard/ngff_cardem/include/board.h@42 
PS2, Line 42: #define PINS_LEDS       PIN_LED_RED, PIN_LED_GREEN 
trailing whitespace


https://gerrit.osmocom.org/c/simtrace2/+/24879/2/firmware/libboard/ngff_cardem/include/board.h@74 
PS2, Line 74: //#define PIN_USIM2_VCC		{PIO_PB2, PIOB, ID_PIOB, PIO_INPUT, PIO_DEFAULT}
Commented out, is it needed?


https://gerrit.osmocom.org/c/simtrace2/+/24879/2/firmware/libboard/ngff_cardem/include/board.h@93 
PS2, Line 93: //#define PIN_SIM_SWITCH1 {PIO_PA20, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT}
Why are those commented, but redefined in sim_switch.c?


https://gerrit.osmocom.org/c/simtrace2/+/24879/2/firmware/libboard/ngff_cardem/source/sim_switch.c 
File firmware/libboard/ngff_cardem/source/sim_switch.c:

https://gerrit.osmocom.org/c/simtrace2/+/24879/2/firmware/libboard/ngff_cardem/source/sim_switch.c@25 
PS2, Line 25: static const Pin pin_conn_usim1 = {PIO_PA20, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT};
Why are those definitions not in board.h as well?



-- 
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/24879
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I9649c853271c22d5403cdf3a7ec9029c9cecfa32
Gerrit-Change-Number: 24879
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: daniel <dwillmann at sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Jul 2021 17:59:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210729/9988cecb/attachment.htm>


More information about the gerrit-log mailing list