<p><a href="https://gerrit.osmocom.org/c/simtrace2/+/24879">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/24879/2/firmware/libboard/ngff_cardem/include/board.h">File firmware/libboard/ngff_cardem/include/board.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/simtrace2/+/24879/2/firmware/libboard/ngff_cardem/include/board.h@42">Patch Set #2, Line 42:</a> <code style="font-family:monospace,monospace">#define PINS_LEDS       PIN_LED_RED, PIN_LED_GREEN </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">trailing whitespace</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/simtrace2/+/24879/2/firmware/libboard/ngff_cardem/include/board.h@74">Patch Set #2, Line 74:</a> <code style="font-family:monospace,monospace">//#define PIN_USIM2_VCC           {PIO_PB2, PIOB, ID_PIOB, PIO_INPUT, PIO_DEFAULT}</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Commented out, is it needed?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/simtrace2/+/24879/2/firmware/libboard/ngff_cardem/include/board.h@93">Patch Set #2, Line 93:</a> <code style="font-family:monospace,monospace">//#define PIN_SIM_SWITCH1 {PIO_PA20, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT}</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why are those commented, but redefined in sim_switch.c?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/24879/2/firmware/libboard/ngff_cardem/source/sim_switch.c">File firmware/libboard/ngff_cardem/source/sim_switch.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/simtrace2/+/24879/2/firmware/libboard/ngff_cardem/source/sim_switch.c@25">Patch Set #2, Line 25:</a> <code style="font-family:monospace,monospace">static const Pin pin_conn_usim1 = {PIO_PA20, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT};</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why are those definitions not in board.h as well?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/simtrace2/+/24879">change 24879</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/simtrace2/+/24879"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9649c853271c22d5403cdf3a7ec9029c9cecfa32 </div>
<div style="display:none"> Gerrit-Change-Number: 24879 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 29 Jul 2021 17:59:38 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>