Change in osmo-pcu[master]: Replace ul_ass_state with osmocom FSM

osmith gerrit-no-reply at lists.osmocom.org
Thu Jul 29 13:18:34 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25056 )

Change subject: Replace ul_ass_state with osmocom FSM
......................................................................


Patch Set 5:

(4 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf_ul_ass_fsm.h 
File src/tbf_ul_ass_fsm.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf_ul_ass_fsm.h@50 
PS4, Line 50: assignment_fsm_timeouts
> (Same for "replace dl_ass_state with osmocom FSM" patch)
Done


https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf_ul_ass_fsm.h@62 
PS4, Line 62: MS_ANR_EV_CREATE_RLCMAC_MSG
> (Same for "replace dl_ass_state with osmocom FSM" patch)
Done


https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf_ul_ass_fsm.c 
File src/tbf_ul_ass_fsm.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf_ul_ass_fsm.c@219 
PS4, Line 219: Plt
> Pkt?
Done


https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf_ul_ass_fsm.c@306 
PS4, Line 306: bool tbf_ul_ass_rts(const struct gprs_rlcmac_tbf* tbf)
> It's common in different osmocom projects like osmo-bts. […]
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25056
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Id414eafe9c04a9a8759c6fb1a483bf2ee093a4d2
Gerrit-Change-Number: 25056
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Jul 2021 13:18:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210729/712a221f/attachment.htm>


More information about the gerrit-log mailing list