Change in osmo-pcu[master]: Replace ul_ass_state with osmocom FSM

osmith gerrit-no-reply at lists.osmocom.org
Thu Jul 29 13:15:10 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25056 )

Change subject: Replace ul_ass_state with osmocom FSM
......................................................................


Patch Set 5: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf.cpp 
File src/tbf.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf.cpp@967 
PS4, Line 967: 	osmo_fsm_inst_update_id(tbf->ul_ass_fsm.fi, buf);
> No need for that, the name of the FSM (which is different for the 2 types) always show up next to th […]
Ack


https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf_ul_ass_fsm.h 
File src/tbf_ul_ass_fsm.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf_ul_ass_fsm.h@32 
PS4, Line 32: 	TBF_UL_ASS_EV_CREATE_RLCMAC_MSG, /* Scheduler wants to gen+Tx the Ass (rej): data=tbf_ul_ass_ev_create_rlcmac_msg_ctx */
> I prefer keeping comment in one line even if it's a few chars too long.
Ack


https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf_ul_ass_fsm.h@52 
PS4, Line 52: fi
> no, the comment is fine. […]
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25056
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Id414eafe9c04a9a8759c6fb1a483bf2ee093a4d2
Gerrit-Change-Number: 25056
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Jul 2021 13:15:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210729/2376d2e4/attachment.htm>


More information about the gerrit-log mailing list