Change in osmo-pcu[master]: replace dl_ass_state with osmocom FSM

pespin gerrit-no-reply at lists.osmocom.org
Thu Jul 29 11:26:40 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25060 )

Change subject: replace dl_ass_state with osmocom FSM
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/25060/1/src/tbf_dl_ass_fsm.c 
File src/tbf_dl_ass_fsm.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/25060/1/src/tbf_dl_ass_fsm.c@72 
PS1, Line 72: 		// FIXME: call tbf_dl_ass_fsm_state_chg(ctx->fi, TBF_DL_ASS_NONE); ?
> unresolved FIXME
That's expected, it wasn't there in previous code I created this from, but while looking at it I saw we may want to use this later. This is left as an improvement for the future.


https://gerrit.osmocom.org/c/osmo-pcu/+/25060/1/src/tbf_dl_ass_fsm.c@88 
PS1, Line 88: 			// FIXME: call tbf_dl_ass_fsm_state_chg(ctx->fi, TBF_DL_ASS_NONE); ?
> unresolved FIXME
Same as above.


https://gerrit.osmocom.org/c/osmo-pcu/+/25060/1/src/tbf_dl_ass_fsm.c@93 
PS1, Line 93: 	new_dl_tbf = ms_dl_tbf(ms);
> previous code had if(ms) around this. […]
Yes, I removed it on purpose while reworking the function in the new place, since a TBF is alweays granted to have an MS. That's a consequence of another big refactoring I did some months ago, and I'm slowly removing this kind of checks from code when I see them.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25060
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia33418478e17986a316ffda48b091030f53fa371
Gerrit-Change-Number: 25060
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Jul 2021 11:26:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210729/6f4ed1e7/attachment.htm>


More information about the gerrit-log mailing list