Change in osmo-pcu[master]: replace dl_ass_state with osmocom FSM

osmith gerrit-no-reply at lists.osmocom.org
Thu Jul 29 08:02:09 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25060 )

Change subject: replace dl_ass_state with osmocom FSM
......................................................................


Patch Set 1:

(6 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/25060/1/src/tbf_dl_ass_fsm.h 
File src/tbf_dl_ass_fsm.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/25060/1/src/tbf_dl_ass_fsm.h@32 
PS1, Line 32: Ul
Dl? Same 2x below


https://gerrit.osmocom.org/c/osmo-pcu/+/25060/1/src/tbf_dl_ass_fsm.h@38 
PS1, Line 38: downlonk
downlink


https://gerrit.osmocom.org/c/osmo-pcu/+/25060/1/src/tbf_dl_ass_fsm.c 
File src/tbf_dl_ass_fsm.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/25060/1/src/tbf_dl_ass_fsm.c@72 
PS1, Line 72: 		// FIXME: call tbf_dl_ass_fsm_state_chg(ctx->fi, TBF_DL_ASS_NONE); ?
unresolved FIXME


https://gerrit.osmocom.org/c/osmo-pcu/+/25060/1/src/tbf_dl_ass_fsm.c@88 
PS1, Line 88: 			// FIXME: call tbf_dl_ass_fsm_state_chg(ctx->fi, TBF_DL_ASS_NONE); ?
unresolved FIXME


https://gerrit.osmocom.org/c/osmo-pcu/+/25060/1/src/tbf_dl_ass_fsm.c@93 
PS1, Line 93: 	new_dl_tbf = ms_dl_tbf(ms);
previous code had if(ms) around this. just to be sure, this was removed on purpose? (I wonder why it was there in the first place.)


https://gerrit.osmocom.org/c/osmo-pcu/+/25060/1/src/tbf_dl_ass_fsm.c@190 
PS1, Line 190: Plt Ul
Pkt Dl?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25060
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia33418478e17986a316ffda48b091030f53fa371
Gerrit-Change-Number: 25060
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Jul 2021 08:02:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210729/d6d71c44/attachment.htm>


More information about the gerrit-log mailing list