Change in osmo-pcu[master]: Replace ul_ass_state with osmocom FSM

osmith gerrit-no-reply at lists.osmocom.org
Thu Jul 29 07:36:30 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25056 )

Change subject: Replace ul_ass_state with osmocom FSM
......................................................................


Patch Set 4:

(3 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf_ul_ass_fsm.h 
File src/tbf_ul_ass_fsm.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf_ul_ass_fsm.h@50 
PS4, Line 50: assignment_fsm_timeouts
> where is assignment_fsm_timeouts defined? (I can't find it, maybe this has been renamed? it's also u […]
(Same for "replace dl_ass_state with osmocom FSM" patch)


https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf_ul_ass_fsm.h@52 
PS4, Line 52: fi
> fi is passed as parameter, so this should be "the_pcu"?
(Same for "replace dl_ass_state with osmocom FSM" patch)


https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf_ul_ass_fsm.h@62 
PS4, Line 62: MS_ANR_EV_CREATE_RLCMAC_MSG
> can't find this, do you mean TBF_UL_ASS_EV_CREATE_RLCMAC_MSG?
(Same for "replace dl_ass_state with osmocom FSM" patch)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25056
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Id414eafe9c04a9a8759c6fb1a483bf2ee093a4d2
Gerrit-Change-Number: 25056
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Jul 2021 07:36:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210729/2b024e17/attachment.htm>


More information about the gerrit-log mailing list