Change in osmo-pcu[master]: Replace ul_ass_state with osmocom FSM

osmith gerrit-no-reply at
Thu Jul 29 07:18:56 UTC 2021

osmith has posted comments on this change. ( )

Change subject: Replace ul_ass_state with osmocom FSM

Patch Set 4:


The only problem I see is having two FSMs with the same ID seems strange, otherwise just some cosmetic comments, rest looks good! 
File src/tbf.cpp: 
PS4, Line 767: s X2000,
why was this removed? (maybe it makes sense to do this in a separate commit and explain it there?) 
PS4, Line 967: 	osmo_fsm_inst_update_id(tbf->, buf);
Why give two separate FSMs the same ID, wouldn't it be better to add some kind of suffix that differentiates them? 
File src/tbf_ul_ass_fsm.h: 
PS4, Line 32: 	TBF_UL_ASS_EV_CREATE_RLCMAC_MSG, /* Scheduler wants to gen+Tx the Ass (rej): data=tbf_ul_ass_ev_create_rlcmac_msg_ctx */
(line length) 
PS4, Line 50: assignment_fsm_timeouts
where is assignment_fsm_timeouts defined? (I can't find it, maybe this has been renamed? it's also used two more times in other comments) 
PS4, Line 52: fi
fi is passed as parameter, so this should be "the_pcu"? 
can't find this, do you mean TBF_UL_ASS_EV_CREATE_RLCMAC_MSG? 
File src/tbf_ul_ass_fsm.c: 
PS4, Line 306: bool tbf_ul_ass_rts(const struct gprs_rlcmac_tbf* tbf)
assuming rts means.... ready to send? would be good to add it as comment

(unless this is a very common abbreviation that I just didn't see much yet)

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Id414eafe9c04a9a8759c6fb1a483bf2ee093a4d2
Gerrit-Change-Number: 25056
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith at>
Gerrit-Comment-Date: Thu, 29 Jul 2021 07:18:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list