Change in osmo-ttcn3-hacks[master]: bsc: add TC_cm_reestablishment

neels gerrit-no-reply at lists.osmocom.org
Tue Jul 27 13:56:12 UTC 2021


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25021 )

Change subject: bsc: add TC_cm_reestablishment
......................................................................


Patch Set 3:

but such enum has to be defined before definition of the COORD_PT in MSC_ConnectionHandler.ttcn.

so for example the coord events needed by TC_cm_reestablishment would have to be defined
in MSC_ConnectionHandler.ttcn.
Each test that uses COORD will have distinct events to send to the other component.
So we collect event names for various tests from various BSC_Tests* files,
all in MSC_ConnectionHandler.ttcn, and it's likely to produce unused entries / cruft as time passes.

Using a charstring does not need this "bloat" in distant source files.
Spotting the wrong strings being sent is not hard, compared to the other pitfalls in ttcn.
Using a const charstring definition gives the same level of compile-time check, if so desired.

So I opt towards de-central flexibility here, rather define the events to be sent close to the actual test,
no need to perfectly validate every COORD message (which an enum would also not do, since it would still be possible to send unrelated enum values at the wrong time...).

Actually, what would be even nicer is allowing *any* type of messages being sent.
Is that possible?


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25021
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1e7d446644f46b8a0a94688e618ffb4f23a8900e
Gerrit-Change-Number: 25021
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 27 Jul 2021 13:56:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210727/182e9022/attachment.htm>


More information about the gerrit-log mailing list