Change in osmo-ttcn3-hacks[master]: bsc: add TC_cm_reestablishment

laforge gerrit-no-reply at lists.osmocom.org
Tue Jul 27 07:31:47 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25021 )

Change subject: bsc: add TC_cm_reestablishment
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25021/3//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25021/3//COMMIT_MSG@1 
PS3, Line 1: Parent:     0882a312 (bsc: split f_start_handler() in two, ..._create() and ..._run())
I'm not really sure I like the fact that we send arbitrary charstrings through the COORD port, rather than some TTCN3 enum.  Using charstring doesn't really seem to provide any benefit here, or am I missing something?

Whether you add another member to the enum, or you add another charstring "const" doesn't really make a difference in terms of future extensions.  The charstring just permits the sender to send invalid values, while the enum would guarantee only one of the permitted (currently 3) values can ever be sent, otherwise a compile-time error would be generated.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25021
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1e7d446644f46b8a0a94688e618ffb4f23a8900e
Gerrit-Change-Number: 25021
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 27 Jul 2021 07:31:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210727/94382b42/attachment.htm>


More information about the gerrit-log mailing list