Change in osmo-ttcn3-hacks[master]: bsc: TC_dyn_pdch_* shorten some delays

neels gerrit-no-reply at lists.osmocom.org
Fri Jul 23 21:49:32 UTC 2021


neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25035 )


Change subject: bsc: TC_dyn_pdch_* shorten some delays
......................................................................

bsc: TC_dyn_pdch_* shorten some delays

So far we're sleeping a hole second before verifying the PDCH status of a
dynamic timeslot. That is just to ensure that osmo-bsc has read the message
from its queue and changed its status.

Change to a sleep of 0.1s, cutting a couple of seconds off the test execution.

Change-Id: Ic6cd373e18aea6eff14f2be5432705b9838e6054
---
M bsc/BSC_Tests.ttcn
1 file changed, 9 insertions(+), 9 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/35/25035/1

diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 47e2ad9..a284932 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -6765,25 +6765,25 @@
 	/* The BSC will activate the dynamic PDCH by default, so confirm that */
 	rsl_unused := f_exp_ipa_rx(0, tr_RSL_IPA_PDCH_ACT(chan_nr));
 	f_ipa_tx(0, ts_RSL_IPA_PDCH_ACT_ACK(chan_nr, ts_RSL_IE_FrameNumber(2342)));
-	f_sleep(1.0);
+	f_sleep(0.1);
 	log("TCH/F_PDCH pchan, PDCH ACT was ACKed, so now in PDCH mode:");
 	f_ts_dyn_mode_assert(0, 0, chan_nr.tn, PDCH_MODE);
 
 	/* De-activate it via VTY */
 	f_dyn_ipa_pdch_deact(0, 0, chan_nr.tn);
-	f_sleep(1.0);
+	f_sleep(0.1);
 	log("TCH/F_PDCH pchan, PDCH DEACT via VTY, so now back in TCH/F mode:");
 	f_ts_dyn_mode_assert(0, 0, chan_nr.tn, TCHF_MODE);
 
 	/* re-activate it via VTY */
 	f_dyn_ipa_pdch_act(0, 0, chan_nr.tn);
-	f_sleep(1.0);
+	f_sleep(0.1);
 	log("TCH/F_PDCH pchan, PDCH ACT via VTY, so now in PDCH mode:");
 	f_ts_dyn_mode_assert(0, 0, chan_nr.tn, PDCH_MODE);
 
 	/* and finally de-activate it again */
 	f_dyn_ipa_pdch_deact(0, 0, chan_nr.tn);
-	f_sleep(1.0);
+	f_sleep(0.1);
 	log("TCH/F_PDCH pchan, PDCH DEACT via VTY, so now back in TCH/F mode:");
 	f_ts_dyn_mode_assert(0, 0, chan_nr.tn, TCHF_MODE);
 
@@ -6811,17 +6811,17 @@
 	/* The BSC will activate the dynamic PDCH by default, so confirm that */
 	rsl_unused := f_exp_ipa_rx(0, tr_RSL_IPA_PDCH_ACT(chan_nr));
 	f_ipa_tx(0, ts_RSL_IPA_PDCH_ACT_ACK(chan_nr, ts_RSL_IE_FrameNumber(2342)));
-	f_sleep(1.0);
+	f_sleep(0.1);
 	f_ts_dyn_mode_assert(0, 0, chan_nr.tn, PDCH_MODE);
 
 	/* De-activate it via VTY */
 	f_dyn_ipa_pdch_deact(0, 0, chan_nr.tn);
-	f_sleep(1.0);
+	f_sleep(0.1);
 	f_ts_dyn_mode_assert(0, 0, chan_nr.tn, TCHF_MODE);
 
 	/* re-activate it via VTY, but fail that; check BSC still assumes TCH/F mode */
 	f_dyn_ipa_pdch_act(0, 0, chan_nr.tn, RSL_ERR_EQUIPMENT_FAIL);
-	f_sleep(1.0);
+	f_sleep(0.1);
 	f_ts_dyn_mode_assert(0, 0, chan_nr.tn, TCHF_MODE);
 
 	/* clean up config */
@@ -6889,7 +6889,7 @@
 	rsl_unused := f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(chan_nr, ?));
 
 	f_ipa_tx(0, ts_RSL_CHAN_ACT_ACK(chan_nr, 2342));
-	f_sleep(1.0);
+	f_sleep(0.1);
 	log("TCH/F_TCH/H_PDCH requested to PDCH ACT on startup, which was ACKed, so now in PDCH:");
 	f_ts_dyn_mode_assert(0, 0, chan_nr.tn, PDCH_MODE);
 
@@ -6919,7 +6919,7 @@
 
 	/* NACK this activation and expect the "show timeslot" mode still to be NONE */
 	f_ipa_tx(0, ts_RSL_CHAN_ACT_NACK(chan_nr, RSL_ERR_EQUIPMENT_FAIL));
-	f_sleep(1.0);
+	f_sleep(0.1);
 	f_ts_dyn_mode_assert(0, 0, chan_nr.tn, NONE_MODE);
 
 	/* clean up config */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25035
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic6cd373e18aea6eff14f2be5432705b9838e6054
Gerrit-Change-Number: 25035
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210723/7bf20ad2/attachment.htm>


More information about the gerrit-log mailing list