<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25035">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: TC_dyn_pdch_* shorten some delays<br><br>So far we're sleeping a hole second before verifying the PDCH status of a<br>dynamic timeslot. That is just to ensure that osmo-bsc has read the message<br>from its queue and changed its status.<br><br>Change to a sleep of 0.1s, cutting a couple of seconds off the test execution.<br><br>Change-Id: Ic6cd373e18aea6eff14f2be5432705b9838e6054<br>---<br>M bsc/BSC_Tests.ttcn<br>1 file changed, 9 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/35/25035/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index 47e2ad9..a284932 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -6765,25 +6765,25 @@</span><br><span>   /* The BSC will activate the dynamic PDCH by default, so confirm that */</span><br><span>     rsl_unused := f_exp_ipa_rx(0, tr_RSL_IPA_PDCH_ACT(chan_nr));</span><br><span>         f_ipa_tx(0, ts_RSL_IPA_PDCH_ACT_ACK(chan_nr, ts_RSL_IE_FrameNumber(2342)));</span><br><span style="color: hsl(0, 100%, 40%);">-     f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_sleep(0.1);</span><br><span>        log("TCH/F_PDCH pchan, PDCH ACT was ACKed, so now in PDCH mode:");</span><br><span>         f_ts_dyn_mode_assert(0, 0, chan_nr.tn, PDCH_MODE);</span><br><span> </span><br><span>       /* De-activate it via VTY */</span><br><span>         f_dyn_ipa_pdch_deact(0, 0, chan_nr.tn);</span><br><span style="color: hsl(0, 100%, 40%);">- f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_sleep(0.1);</span><br><span>        log("TCH/F_PDCH pchan, PDCH DEACT via VTY, so now back in TCH/F mode:");</span><br><span>   f_ts_dyn_mode_assert(0, 0, chan_nr.tn, TCHF_MODE);</span><br><span> </span><br><span>       /* re-activate it via VTY */</span><br><span>         f_dyn_ipa_pdch_act(0, 0, chan_nr.tn);</span><br><span style="color: hsl(0, 100%, 40%);">-   f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_sleep(0.1);</span><br><span>        log("TCH/F_PDCH pchan, PDCH ACT via VTY, so now in PDCH mode:");</span><br><span>   f_ts_dyn_mode_assert(0, 0, chan_nr.tn, PDCH_MODE);</span><br><span> </span><br><span>       /* and finally de-activate it again */</span><br><span>       f_dyn_ipa_pdch_deact(0, 0, chan_nr.tn);</span><br><span style="color: hsl(0, 100%, 40%);">- f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_sleep(0.1);</span><br><span>        log("TCH/F_PDCH pchan, PDCH DEACT via VTY, so now back in TCH/F mode:");</span><br><span>   f_ts_dyn_mode_assert(0, 0, chan_nr.tn, TCHF_MODE);</span><br><span> </span><br><span>@@ -6811,17 +6811,17 @@</span><br><span>     /* The BSC will activate the dynamic PDCH by default, so confirm that */</span><br><span>     rsl_unused := f_exp_ipa_rx(0, tr_RSL_IPA_PDCH_ACT(chan_nr));</span><br><span>         f_ipa_tx(0, ts_RSL_IPA_PDCH_ACT_ACK(chan_nr, ts_RSL_IE_FrameNumber(2342)));</span><br><span style="color: hsl(0, 100%, 40%);">-     f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_sleep(0.1);</span><br><span>        f_ts_dyn_mode_assert(0, 0, chan_nr.tn, PDCH_MODE);</span><br><span> </span><br><span>       /* De-activate it via VTY */</span><br><span>         f_dyn_ipa_pdch_deact(0, 0, chan_nr.tn);</span><br><span style="color: hsl(0, 100%, 40%);">- f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_sleep(0.1);</span><br><span>        f_ts_dyn_mode_assert(0, 0, chan_nr.tn, TCHF_MODE);</span><br><span> </span><br><span>       /* re-activate it via VTY, but fail that; check BSC still assumes TCH/F mode */</span><br><span>      f_dyn_ipa_pdch_act(0, 0, chan_nr.tn, RSL_ERR_EQUIPMENT_FAIL);</span><br><span style="color: hsl(0, 100%, 40%);">-   f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_sleep(0.1);</span><br><span>        f_ts_dyn_mode_assert(0, 0, chan_nr.tn, TCHF_MODE);</span><br><span> </span><br><span>       /* clean up config */</span><br><span>@@ -6889,7 +6889,7 @@</span><br><span>        rsl_unused := f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(chan_nr, ?));</span><br><span> </span><br><span>         f_ipa_tx(0, ts_RSL_CHAN_ACT_ACK(chan_nr, 2342));</span><br><span style="color: hsl(0, 100%, 40%);">-        f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_sleep(0.1);</span><br><span>        log("TCH/F_TCH/H_PDCH requested to PDCH ACT on startup, which was ACKed, so now in PDCH:");</span><br><span>        f_ts_dyn_mode_assert(0, 0, chan_nr.tn, PDCH_MODE);</span><br><span> </span><br><span>@@ -6919,7 +6919,7 @@</span><br><span> </span><br><span>   /* NACK this activation and expect the "show timeslot" mode still to be NONE */</span><br><span>    f_ipa_tx(0, ts_RSL_CHAN_ACT_NACK(chan_nr, RSL_ERR_EQUIPMENT_FAIL));</span><br><span style="color: hsl(0, 100%, 40%);">-     f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_sleep(0.1);</span><br><span>        f_ts_dyn_mode_assert(0, 0, chan_nr.tn, NONE_MODE);</span><br><span> </span><br><span>       /* clean up config */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25035">change 25035</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25035"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic6cd373e18aea6eff14f2be5432705b9838e6054 </div>
<div style="display:none"> Gerrit-Change-Number: 25035 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>