Change in osmo-ttcn3-hacks[master]: bsc: add TC_cm_reestablishment

pespin gerrit-no-reply at lists.osmocom.org
Fri Jul 23 12:51:02 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25021 )

Change subject: bsc: add TC_cm_reestablishment
......................................................................


Patch Set 1:

(4 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25021/1/bsc/BSC_Tests.ttcn 
File bsc/BSC_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25021/1/bsc/BSC_Tests.ttcn@9337 
PS1, Line 9337: 	f_sleep(2.0);
Can't you COORD.recv() something here instead of f_sleep?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25021/1/bsc/BSC_Tests.ttcn@9338 
PS1, Line 9338: 	COORD.send("Lost connection");
Did you think about using something more "tokenized" when passing the strings? "EV_LOST_CONNECTION" or alike. IMHo would be easier to track and find where are they sent received.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25021/1/bsc/BSC_Tests.ttcn@9342 
PS1, Line 9342: 	[] COORD.receive("Clear");
EV_CLEAR


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25021/1/bsc/BSC_Tests.ttcn@9355 
PS1, Line 9355: 	COORD.send("Clear done");
EV_CLEAR_ACK



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25021
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1e7d446644f46b8a0a94688e618ffb4f23a8900e
Gerrit-Change-Number: 25021
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Jul 2021 12:51:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210723/75b5d314/attachment.htm>


More information about the gerrit-log mailing list