<p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25021">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25021/1/bsc/BSC_Tests.ttcn">File bsc/BSC_Tests.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25021/1/bsc/BSC_Tests.ttcn@9337">Patch Set #1, Line 9337:</a> <code style="font-family:monospace,monospace">   f_sleep(2.0);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Can't you COORD.recv() something here instead of f_sleep?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25021/1/bsc/BSC_Tests.ttcn@9338">Patch Set #1, Line 9338:</a> <code style="font-family:monospace,monospace">   COORD.send("Lost connection");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Did you think about using something more "tokenized" when passing the strings? "EV_LOST_CONNECTION" or alike. IMHo would be easier to track and find where are they sent received.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25021/1/bsc/BSC_Tests.ttcn@9342">Patch Set #1, Line 9342:</a> <code style="font-family:monospace,monospace">       [] COORD.receive("Clear");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">EV_CLEAR</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25021/1/bsc/BSC_Tests.ttcn@9355">Patch Set #1, Line 9355:</a> <code style="font-family:monospace,monospace"> COORD.send("Clear done");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">EV_CLEAR_ACK</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25021">change 25021</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25021"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1e7d446644f46b8a0a94688e618ffb4f23a8900e </div>
<div style="display:none"> Gerrit-Change-Number: 25021 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 23 Jul 2021 12:51:02 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>