Change in osmo-bsc[master]: Split bts_vty.c creating bts_trx_vty.c

pespin gerrit-no-reply at lists.osmocom.org
Fri Jul 23 11:29:44 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24980 )

Change subject: Split bts_vty.c creating bts_trx_vty.c
......................................................................


Patch Set 3:

> Patch Set 3:
> 
> (2 comments)
> 
> ok, but why? any functional reason?
> 
> in osmo-bsc, i recently moved osmo_bsc_vty.c into bsc_vty.c to have less file splits and find DEFUNs easier. same as i still do with my two bicycle bags: i always looked in the first, didn't find it, then looked in the other, still didn't find it, to finally do find it in the first...

Because it becomes really cumbersome to find or maintain bsc_vty.c, having it more than 7K lines before the split. I usually find myself losing time finding where to put new stuff in, or finding in which node one comamnd is, etc.

The main difference in joining osmo_bsc_vty.c into bsc_vty.c and splitting into bts_{trx_}_vty.c is that in the former there was no clear separation/distinction between those, so having them separated only added confusion. In this new split, stuff it separated based on node hierarchy. Furthermore, we already have a bts.c and bts_trx.c files. Also so simply grepping in the directory and finding something in bts_trx_vty.c already tells you the vty cmd is in TRX or TS node, and lookinng it up there is easy.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24980
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I15ec8f71a5d31915162cb3ad75ea77e934fa4887
Gerrit-Change-Number: 24980
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Jul 2021 11:29:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210723/0f1c5d4c/attachment.htm>


More information about the gerrit-log mailing list