Change in osmo-bsc[master]: Split bts_vty.c creating bts_trx_vty.c

neels gerrit-no-reply at lists.osmocom.org
Fri Jul 23 02:00:21 UTC 2021


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24980 )

Change subject: Split bts_vty.c creating bts_trx_vty.c
......................................................................


Patch Set 3:

(2 comments)

ok, but why? any functional reason?

in osmo-bsc, i recently moved osmo_bsc_vty.c into bsc_vty.c to have less file splits and find DEFUNs easier. same as i still do with my two bicycle bags: i always looked in the first, didn't find it, then looked in the other, still didn't find it, to finally do find it in the first...

https://gerrit.osmocom.org/c/osmo-bsc/+/24980/3/src/osmo-bsc/bts_trx_vty.c 
File src/osmo-bsc/bts_trx_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24980/3/src/osmo-bsc/bts_trx_vty.c@1 
PS3, Line 1: /* OsmoBSC interface to quagga VTY, BTS node */
TRX node?


https://gerrit.osmocom.org/c/osmo-bsc/+/24980/3/src/osmo-bsc/bts_trx_vty.c@2 
PS3, Line 2: /* (C) 2009-2017 by Harald Welte <laforge at gnumonks.org>
new date?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24980
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I15ec8f71a5d31915162cb3ad75ea77e934fa4887
Gerrit-Change-Number: 24980
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Jul 2021 02:00:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210723/7131cc7c/attachment.htm>


More information about the gerrit-log mailing list