Change in osmo-bsc[master]: RES IND: allow empty Resource Information IE

neels gerrit-no-reply at lists.osmocom.org
Thu Jul 22 12:15:36 UTC 2021


neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25002 )

Change subject: RES IND: allow empty Resource Information IE
......................................................................

RES IND: allow empty Resource Information IE

If all channels of a BTS are in use and there are no interference
ratings to be reported, the Resource Information IE may be empty. Do not
log this as an error, it is not something that needs operator attention.

Related: SYS#5313
Change-Id: I75b851ef1269674f43db3fb3a48518e76182d7f0
---
M src/osmo-bsc/abis_rsl.c
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index f6ae19a..02037e1 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -1492,7 +1492,7 @@
 		}
 	}
 
-	res_info_ie = TLVP_GET_MINLEN(&tp, RSL_IE_RESOURCE_INFO, 2);
+	res_info_ie = TLVP_GET(&tp, RSL_IE_RESOURCE_INFO);
 	if (!res_info_ie) {
 		LOGP(DRSL, LOGL_ERROR, "Rx Resource Indication: missing Resource Info IE\n");
 		return -ENOENT;
@@ -1510,7 +1510,9 @@
 		return -EINVAL;
 	}
 
-	/* Now iterate the reported levels and update corresponding lchans */
+	/* Now iterate the reported levels and update corresponding lchans.
+	 * Note that an empty res_info_ie can also make sense, if no lchans are idle and no interference ratings are
+	 * present. The practical effect of the message then is to invalidate previous interference ratings. */
 	for (i = 0; i < res_info_ie->len; i += 2) {
 		struct gsm_bts *bts = trx->bts;
 		uint8_t chan_nr = res_info_ie->val[i];

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25002
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I75b851ef1269674f43db3fb3a48518e76182d7f0
Gerrit-Change-Number: 25002
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210722/d0c3d1cc/attachment.htm>


More information about the gerrit-log mailing list