Change in osmo-bsc[master]: RES IND: tweak error code on missing Resource Information IE

neels gerrit-no-reply at lists.osmocom.org
Wed Jul 21 23:59:04 UTC 2021


neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25003 )


Change subject: RES IND: tweak error code on missing Resource Information IE
......................................................................

RES IND: tweak error code on missing Resource Information IE

If the RES IND message is invalid, let's not return ENOENT which
translates to "No such file or directory", instead return EINVAL.

Related: SYS#5313
Change-Id: Ifd700e90c881874d428f2860603a4ddbf13d705e
---
M src/osmo-bsc/abis_rsl.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/03/25003/1

diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index b491285..ed45c64 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -1495,7 +1495,7 @@
 	res_info_ie = TLVP_GET(&tp, RSL_IE_RESOURCE_INFO);
 	if (!res_info_ie) {
 		LOGP(DRSL, LOGL_ERROR, "Rx Resource Indication: missing Resource Info IE\n");
-		return -ENOENT;
+		return -EINVAL;
 	}
 
 	/* The IE value is defined in 3GPP TS 48.058 9.3.21 Resource Information:

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25003
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ifd700e90c881874d428f2860603a4ddbf13d705e
Gerrit-Change-Number: 25003
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210721/c6f87348/attachment.htm>


More information about the gerrit-log mailing list