This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24942 ) Change subject: mgcp_ratectr: add stats items to monitor trunk usage ...................................................................... Patch Set 5: (2 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/24942/4/src/libosmo-mgcp/mgcp_endp.c File src/libosmo-mgcp/mgcp_endp.c: https://gerrit.osmocom.org/c/osmo-mgw/+/24942/4/src/libosmo-mgcp/mgcp_endp.c@138 PS4, Line 138: if (endp->trunk->stats.common) { > There is a problem with the unit-tests. […] Then I'd fix the unit tests to do proper stuff instead of adding specific code paths for unit tests like here. https://gerrit.osmocom.org/c/osmo-mgw/+/24942/4/src/libosmo-mgcp/mgcp_ratectr.c File src/libosmo-mgcp/mgcp_ratectr.c: https://gerrit.osmocom.org/c/osmo-mgw/+/24942/4/src/libosmo-mgcp/mgcp_ratectr.c@285 PS4, Line 285: snprintf(stat_name, sizeof(stat_name), "%s-%d:common", mgcp_trunk_type_strs_str(trunk->trunk_type), > I also don't understand why, I should check this back and refactor it too (if possible) - but it wou […] sure no problem, I was just asking to make sure it was not already a unsigned int. Even if it's an int it may make more sense to put it as a %u in case at a later stage you move it to be unsigned, so that you then don't forget to change %d->%u here. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24942 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib7b654168dc3512f55e45cc4755dc1f6f423d023 Gerrit-Change-Number: 24942 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 19 Jul 2021 10:51:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Comment-In-Reply-To: dexter <pmaier at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210719/a0904739/attachment.htm>