This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24942 ) Change subject: mgcp_ratectr: add stats items to monitor trunk usage ...................................................................... Patch Set 5: (3 comments) thanks for the review comments. I really think we should do something about the trunk_nr: #define LOGPTRUNK(trunk, cat, level, fmt, args...) \ LOGP(cat, level, "trunk:%u " fmt, \ <============ %u (!) trunk ? trunk->trunk_nr : 0, \ ## args) https://gerrit.osmocom.org/c/osmo-mgw/+/24942/4/src/libosmo-mgcp/mgcp_endp.c File src/libosmo-mgcp/mgcp_endp.c: https://gerrit.osmocom.org/c/osmo-mgw/+/24942/4/src/libosmo-mgcp/mgcp_endp.c@138 PS4, Line 138: if (endp->trunk->stats.common) { > can this be null? does it make sense that it's null? There is a problem with the unit-tests. They do not allocate the trunks really, they just create a variable with some endpoints in it, which are also variables. If I don't check, it crashes. https://gerrit.osmocom.org/c/osmo-mgw/+/24942/4/src/libosmo-mgcp/mgcp_ratectr.c File src/libosmo-mgcp/mgcp_ratectr.c: https://gerrit.osmocom.org/c/osmo-mgw/+/24942/4/src/libosmo-mgcp/mgcp_ratectr.c@257 PS4, Line 257: "Number of endpoints that exist on the trunk", > string not aligned to above line Done https://gerrit.osmocom.org/c/osmo-mgw/+/24942/4/src/libosmo-mgcp/mgcp_ratectr.c@285 PS4, Line 285: snprintf(stat_name, sizeof(stat_name), "%s-%d:common", mgcp_trunk_type_strs_str(trunk->trunk_type), > is trunk_nr an int? I also don't understand why, I should check this back and refactor it too (if possible) - but it would be easier if we could do this in a follow up patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24942 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib7b654168dc3512f55e45cc4755dc1f6f423d023 Gerrit-Change-Number: 24942 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 19 Jul 2021 10:01:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210719/0d69419f/attachment.htm>