Change in osmo-bsc[master]: vty 'interference-meas level-bounds': explain duality in ordering

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24888 )

Change subject: vty 'interference-meas level-bounds': explain duality in ordering
......................................................................

vty 'interference-meas level-bounds': explain duality in ordering

Related: SYS#5313
Change-Id: If71e20e95d29e7f03739ee04e1ef429bf8bd51ed
---
M src/osmo-bsc/bsc_vty.c
M tests/interf_meas.vty
2 files changed, 4 insertions(+), 3 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  neels: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index 1eeda3b..d76d02d 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -5051,7 +5051,9 @@
 	      "interference-meas level-bounds "
 		"<-120-0> <-120-0> <-120-0> <-120-0> <-120-0> <-120-0>",
 	      "Interference measurement parameters\n"
-	      "Interference level Boundaries\n"
+	      "Interference level Boundaries. 3GPP do not specify whether these should be in ascending or descending"
+	      " order (3GPP TS 48.058 9.3.21 / 3GPP TS 52.021 9.4.25). OsmoBSC supports either ordering, but possibly"
+	      " some BTS models only return meaningful interference levels with one specific ordering.\n"
 	      "Interference boundary 0 (dBm)\n"
 	      "Interference boundary X1 (dBm)\n"
 	      "Interference boundary X2 (dBm)\n"
@@ -5064,7 +5066,6 @@
 
 	for (i = 0; i < ARRAY_SIZE(bts->interf_meas_params_cfg.bounds_dbm); i++) {
 		bts->interf_meas_params_cfg.bounds_dbm[i] = abs(atoi(argv[i]));
-		/* TODO: ensure ascending (or descending?) order */
 	}
 	return CMD_SUCCESS;
 }
diff --git a/tests/interf_meas.vty b/tests/interf_meas.vty
index 76b33e5..c6d8fb4 100644
--- a/tests/interf_meas.vty
+++ b/tests/interf_meas.vty
@@ -12,7 +12,7 @@
   interference-meas  Interference measurement parameters
 OsmoBSC(config-net-bts)# interference-meas ?
   avg-period    Averaging period (Intave)
-  level-bounds  Interference level Boundaries
+  level-bounds  Interference level Boundaries. 3GPP do not specify whether these should be in ascending or descending order (3GPP TS 48.058 9.3.21 / 3GPP TS 52.021 9.4.25). OsmoBSC supports either ordering, but possibly some BTS models only return meaningful interference levels with one specific ordering.
 
 OsmoBSC(config-net-bts)# ### Averaging period
 OsmoBSC(config-net-bts)# interference-meas avg-period ?

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24888
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If71e20e95d29e7f03739ee04e1ef429bf8bd51ed
Gerrit-Change-Number: 24888
Gerrit-PatchSet: 6
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210716/ecbe9f69/attachment.htm>