<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24888">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, but someone else must approve
  neels: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty 'interference-meas level-bounds': explain duality in ordering<br><br>Related: SYS#5313<br>Change-Id: If71e20e95d29e7f03739ee04e1ef429bf8bd51ed<br>---<br>M src/osmo-bsc/bsc_vty.c<br>M tests/interf_meas.vty<br>2 files changed, 4 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c</span><br><span>index 1eeda3b..d76d02d 100644</span><br><span>--- a/src/osmo-bsc/bsc_vty.c</span><br><span>+++ b/src/osmo-bsc/bsc_vty.c</span><br><span>@@ -5051,7 +5051,9 @@</span><br><span>               "interference-meas level-bounds "</span><br><span>            "<-120-0> <-120-0> <-120-0> <-120-0> <-120-0> <-120-0>",</span><br><span>             "Interference measurement parameters\n"</span><br><span style="color: hsl(0, 100%, 40%);">-       "Interference level Boundaries\n"</span><br><span style="color: hsl(120, 100%, 40%);">+           "Interference level Boundaries. 3GPP do not specify whether these should be in ascending or descending"</span><br><span style="color: hsl(120, 100%, 40%);">+             " order (3GPP TS 48.058 9.3.21 / 3GPP TS 52.021 9.4.25). OsmoBSC supports either ordering, but possibly"</span><br><span style="color: hsl(120, 100%, 40%);">+            " some BTS models only return meaningful interference levels with one specific ordering.\n"</span><br><span>        "Interference boundary 0 (dBm)\n"</span><br><span>          "Interference boundary X1 (dBm)\n"</span><br><span>         "Interference boundary X2 (dBm)\n"</span><br><span>@@ -5064,7 +5066,6 @@</span><br><span> </span><br><span>       for (i = 0; i < ARRAY_SIZE(bts->interf_meas_params_cfg.bounds_dbm); i++) {</span><br><span>             bts->interf_meas_params_cfg.bounds_dbm[i] = abs(atoi(argv[i]));</span><br><span style="color: hsl(0, 100%, 40%);">-              /* TODO: ensure ascending (or descending?) order */</span><br><span>  }</span><br><span>    return CMD_SUCCESS;</span><br><span> }</span><br><span>diff --git a/tests/interf_meas.vty b/tests/interf_meas.vty</span><br><span>index 76b33e5..c6d8fb4 100644</span><br><span>--- a/tests/interf_meas.vty</span><br><span>+++ b/tests/interf_meas.vty</span><br><span>@@ -12,7 +12,7 @@</span><br><span>   interference-meas  Interference measurement parameters</span><br><span> OsmoBSC(config-net-bts)# interference-meas ?</span><br><span>   avg-period    Averaging period (Intave)</span><br><span style="color: hsl(0, 100%, 40%);">-  level-bounds  Interference level Boundaries</span><br><span style="color: hsl(120, 100%, 40%);">+  level-bounds  Interference level Boundaries. 3GPP do not specify whether these should be in ascending or descending order (3GPP TS 48.058 9.3.21 / 3GPP TS 52.021 9.4.25). OsmoBSC supports either ordering, but possibly some BTS models only return meaningful interference levels with one specific ordering.</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# ### Averaging period</span><br><span> OsmoBSC(config-net-bts)# interference-meas avg-period ?</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24888">change 24888</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/24888"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If71e20e95d29e7f03739ee04e1ef429bf8bd51ed </div>
<div style="display:none"> Gerrit-Change-Number: 24888 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>