Change in osmo-ci[master]: lint: ignore PREFER_DEFINED_ATTRIBUTE_MACRO

laforge gerrit-no-reply at lists.osmocom.org
Fri Jul 16 16:01:15 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/24921 )

Change subject: lint: ignore PREFER_DEFINED_ATTRIBUTE_MACRO
......................................................................

lint: ignore PREFER_DEFINED_ATTRIBUTE_MACRO

Don't complain that macros such as __packed should be used, which are
defined in the Linux kernel but not in libosmocore.

For example:
src/gsm/gsm0808.c:85: WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed))

Related: OS#5087
Change-Id: I2bf3b7d60e99cf91f7b619af54167a11cdfae8c6
---
M lint/checkpatch/checkpatch_osmo.sh
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved; Verified
  pespin: Looks good to me, but someone else must approve



diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh
index 4be1348..88f0b2d 100755
--- a/lint/checkpatch/checkpatch_osmo.sh
+++ b/lint/checkpatch/checkpatch_osmo.sh
@@ -21,6 +21,7 @@
 # * INITIALISED_STATIC: we use this, see also http://lkml.iu.edu/hypermail/linux/kernel/0808.1/2235.html
 # * LINE_CONTINUATIONS: false positives
 # * LINE_SPACING: we don't always put a blank line after declarations
+# * PREFER_DEFINED_ATTRIBUTE_MACRO: macros like __packed not defined in libosmocore
 # * PREFER_FALLTHROUGH: pseudo keyword macro "fallthrough" is not defined in libosmocore
 # * REPEATED_WORD: false positives in doxygen descriptions (e.g. '\param[in] data Data passed through...')
 # * SPDX_LICENSE_TAG: we don't place it on line 1
@@ -45,6 +46,7 @@
 	--ignore INITIALISED_STATIC \
 	--ignore LINE_CONTINUATIONS \
 	--ignore LINE_SPACING \
+	--ignore PREFER_DEFINED_ATTRIBUTE_MACRO \
 	--ignore PREFER_FALLTHROUGH \
 	--ignore REPEATED_WORD \
 	--ignore SPDX_LICENSE_TAG \

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/24921
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I2bf3b7d60e99cf91f7b619af54167a11cdfae8c6
Gerrit-Change-Number: 24921
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210716/de721290/attachment.htm>


More information about the gerrit-log mailing list