<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ci/+/24921">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved; Verified
  pespin: Looks good to me, but someone else must approve

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lint: ignore PREFER_DEFINED_ATTRIBUTE_MACRO<br><br>Don't complain that macros such as __packed should be used, which are<br>defined in the Linux kernel but not in libosmocore.<br><br>For example:<br>src/gsm/gsm0808.c:85: WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed))<br><br>Related: OS#5087<br>Change-Id: I2bf3b7d60e99cf91f7b619af54167a11cdfae8c6<br>---<br>M lint/checkpatch/checkpatch_osmo.sh<br>1 file changed, 2 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh</span><br><span>index 4be1348..88f0b2d 100755</span><br><span>--- a/lint/checkpatch/checkpatch_osmo.sh</span><br><span>+++ b/lint/checkpatch/checkpatch_osmo.sh</span><br><span>@@ -21,6 +21,7 @@</span><br><span> # * INITIALISED_STATIC: we use this, see also http://lkml.iu.edu/hypermail/linux/kernel/0808.1/2235.html</span><br><span> # * LINE_CONTINUATIONS: false positives</span><br><span> # * LINE_SPACING: we don't always put a blank line after declarations</span><br><span style="color: hsl(120, 100%, 40%);">+# * PREFER_DEFINED_ATTRIBUTE_MACRO: macros like __packed not defined in libosmocore</span><br><span> # * PREFER_FALLTHROUGH: pseudo keyword macro "fallthrough" is not defined in libosmocore</span><br><span> # * REPEATED_WORD: false positives in doxygen descriptions (e.g. '\param[in] data Data passed through...')</span><br><span> # * SPDX_LICENSE_TAG: we don't place it on line 1</span><br><span>@@ -45,6 +46,7 @@</span><br><span>  --ignore INITIALISED_STATIC \</span><br><span>        --ignore LINE_CONTINUATIONS \</span><br><span>        --ignore LINE_SPACING \</span><br><span style="color: hsl(120, 100%, 40%);">+       --ignore PREFER_DEFINED_ATTRIBUTE_MACRO \</span><br><span>    --ignore PREFER_FALLTHROUGH \</span><br><span>        --ignore REPEATED_WORD \</span><br><span>     --ignore SPDX_LICENSE_TAG \</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ci/+/24921">change 24921</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ci/+/24921"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ci </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2bf3b7d60e99cf91f7b619af54167a11cdfae8c6 </div>
<div style="display:none"> Gerrit-Change-Number: 24921 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>