Change in osmo-bsc[master]: _select_sdcch_for_call: Avoid 2nd lchan lookup when finally selecting it

pespin gerrit-no-reply at lists.osmocom.org
Thu Jul 15 11:30:10 UTC 2021


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24950 )


Change subject: _select_sdcch_for_call: Avoid 2nd lchan lookup when finally selecting it
......................................................................

_select_sdcch_for_call: Avoid 2nd lchan lookup when finally selecting it

We already looked it up, it's not necessary to look it up again by
calling lchan_select_by_type(). Let's instead call lchan_select()
directly on the lchan pointer.

Related: SYS#5309
Change-Id: I1054c18f58c9e249f263e3e97a365a1fd8b03a93
---
M src/osmo-bsc/abis_rsl.c
1 file changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/50/24950/1

diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index 42d77b3..b1cbb5d 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -1964,8 +1964,7 @@
 	}
 
 select_lchan:
-	/* FIXME: we already have lchan, simply do lchan->type = GSM_LCHAN_SDCCH? Split lchan_select_by_type in 2 functions? */
-	lchan = lchan_select_by_type(bts, GSM_LCHAN_SDCCH);
+	lchan_select(lchan, GSM_LCHAN_SDCCH);
 	return lchan;
 }
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24950
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1054c18f58c9e249f263e3e97a365a1fd8b03a93
Gerrit-Change-Number: 24950
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210715/5517aee4/attachment.htm>


More information about the gerrit-log mailing list