<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24950">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">_select_sdcch_for_call: Avoid 2nd lchan lookup when finally selecting it<br><br>We already looked it up, it's not necessary to look it up again by<br>calling lchan_select_by_type(). Let's instead call lchan_select()<br>directly on the lchan pointer.<br><br>Related: SYS#5309<br>Change-Id: I1054c18f58c9e249f263e3e97a365a1fd8b03a93<br>---<br>M src/osmo-bsc/abis_rsl.c<br>1 file changed, 1 insertion(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/50/24950/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c</span><br><span>index 42d77b3..b1cbb5d 100644</span><br><span>--- a/src/osmo-bsc/abis_rsl.c</span><br><span>+++ b/src/osmo-bsc/abis_rsl.c</span><br><span>@@ -1964,8 +1964,7 @@</span><br><span>      }</span><br><span> </span><br><span> select_lchan:</span><br><span style="color: hsl(0, 100%, 40%);">-  /* FIXME: we already have lchan, simply do lchan->type = GSM_LCHAN_SDCCH? Split lchan_select_by_type in 2 functions? */</span><br><span style="color: hsl(0, 100%, 40%);">-      lchan = lchan_select_by_type(bts, GSM_LCHAN_SDCCH);</span><br><span style="color: hsl(120, 100%, 40%);">+   lchan_select(lchan, GSM_LCHAN_SDCCH);</span><br><span>        return lchan;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24950">change 24950</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/24950"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1054c18f58c9e249f263e3e97a365a1fd8b03a93 </div>
<div style="display:none"> Gerrit-Change-Number: 24950 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>