Change in osmo-bsc[master]: lchan_fsm: fix potential NULL-pointer dereference

neels gerrit-no-reply at lists.osmocom.org
Sun Jul 11 11:31:22 UTC 2021


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24908 )

Change subject: lchan_fsm: fix potential NULL-pointer dereference
......................................................................


Patch Set 1: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/24908/1/src/osmo-bsc/lchan_fsm.c 
File src/osmo-bsc/lchan_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24908/1/src/osmo-bsc/lchan_fsm.c@145 
PS1, Line 145: 		if (for_conn != NULL && for_conn->assignment.fi != NULL) {
would be nicer if you copy below error handling and s/Handover/Assignment in the err msgs


https://gerrit.osmocom.org/c/osmo-bsc/+/24908/1/src/osmo-bsc/lchan_fsm.c@155 
PS1, Line 155: 		if (!for_conn) {
...this


https://gerrit.osmocom.org/c/osmo-bsc/+/24908/1/src/osmo-bsc/lchan_fsm.c@161 
PS1, Line 161: 		if (!for_conn->ho.fi) {
...and this



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24908
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I373855b95f8bde0ce8f9c2ae7bf95c9135d33484
Gerrit-Change-Number: 24908
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Sun, 11 Jul 2021 11:31:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210711/3bb57119/attachment.htm>


More information about the gerrit-log mailing list