Change in osmo-bsc[master]: lchan_fsm: fix potential NULL-pointer dereference

fixeria gerrit-no-reply at lists.osmocom.org
Sun Jul 11 07:20:01 UTC 2021


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24908 )


Change subject: lchan_fsm: fix potential NULL-pointer dereference
......................................................................

lchan_fsm: fix potential NULL-pointer dereference

Change-Id: I373855b95f8bde0ce8f9c2ae7bf95c9135d33484
Related: SYS#5526
---
M src/osmo-bsc/lchan_fsm.c
1 file changed, 5 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/08/24908/1

diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c
index 841415f..e956a49 100644
--- a/src/osmo-bsc/lchan_fsm.c
+++ b/src/osmo-bsc/lchan_fsm.c
@@ -142,8 +142,11 @@
 	case ACTIVATE_FOR_ASSIGNMENT:
 		LOG_LCHAN(lchan, LOGL_NOTICE, "Signalling Assignment FSM of error (%s)\n",
 			  lchan->last_error ? : "unknown error");
-		_osmo_fsm_inst_dispatch(for_conn->assignment.fi, ASSIGNMENT_EV_LCHAN_ERROR, lchan,
-					file, line);
+		if (for_conn != NULL && for_conn->assignment.fi != NULL) {
+			_osmo_fsm_inst_dispatch(for_conn->assignment.fi,
+						ASSIGNMENT_EV_LCHAN_ERROR,
+						lchan, file, line);
+		}
 		return;
 
 	case ACTIVATE_FOR_HANDOVER:

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24908
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I373855b95f8bde0ce8f9c2ae7bf95c9135d33484
Gerrit-Change-Number: 24908
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210711/d1b6f6b6/attachment.htm>


More information about the gerrit-log mailing list