Change in libosmocore[master]: gprs_ns2: use gprs_ns2_free_bind() to clean up a bind

lynxis lazus gerrit-no-reply at lists.osmocom.org
Tue Jul 6 09:03:48 UTC 2021


lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/24856 )


Change subject: gprs_ns2: use gprs_ns2_free_bind() to clean up a bind
......................................................................

gprs_ns2: use gprs_ns2_free_bind() to clean up a bind

gprs_ns2_free_bind() takes care of all required steps to clean up a bind.
The driver->free_bind() operation only cleans up the driver internal state
but not NSVCs and other generic things.

Change-Id: I0a2ad22905bcacb929b9b5f5b034af0da3081826
---
M src/gb/gprs_ns2_vty.c
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/56/24856/1

diff --git a/src/gb/gprs_ns2_vty.c b/src/gb/gprs_ns2_vty.c
index 705b60e..2f540c2 100644
--- a/src/gb/gprs_ns2_vty.c
+++ b/src/gb/gprs_ns2_vty.c
@@ -423,7 +423,7 @@
 	vty_bind_free(vbind);
 	bind = gprs_ns2_bind_by_name(vty_nsi, name);
 	if (bind)
-		bind->driver->free_bind(bind);
+		gprs_ns2_free_bind(bind);
 	return CMD_SUCCESS;
 }
 
@@ -678,7 +678,7 @@
 		return CMD_ERR_NOTHING_TODO;
 
 	OSMO_ASSERT(bind->ll == GPRS_NS2_LL_UDP);
-	bind->driver->free_bind(bind);
+	gprs_ns2_free_bind(bind);
 	return CMD_SUCCESS;
 }
 
@@ -939,7 +939,7 @@
 		return CMD_WARNING;
 	}
 
-	bind->driver->free_bind(bind);
+	gprs_ns2_free_bind(bind);
 	return CMD_SUCCESS;
 }
 

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24856
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0a2ad22905bcacb929b9b5f5b034af0da3081826
Gerrit-Change-Number: 24856
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210706/2d4804c3/attachment.htm>


More information about the gerrit-log mailing list