<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/24856">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2: use gprs_ns2_free_bind() to clean up a bind<br><br>gprs_ns2_free_bind() takes care of all required steps to clean up a bind.<br>The driver->free_bind() operation only cleans up the driver internal state<br>but not NSVCs and other generic things.<br><br>Change-Id: I0a2ad22905bcacb929b9b5f5b034af0da3081826<br>---<br>M src/gb/gprs_ns2_vty.c<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/56/24856/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_vty.c b/src/gb/gprs_ns2_vty.c</span><br><span>index 705b60e..2f540c2 100644</span><br><span>--- a/src/gb/gprs_ns2_vty.c</span><br><span>+++ b/src/gb/gprs_ns2_vty.c</span><br><span>@@ -423,7 +423,7 @@</span><br><span>       vty_bind_free(vbind);</span><br><span>        bind = gprs_ns2_bind_by_name(vty_nsi, name);</span><br><span>         if (bind)</span><br><span style="color: hsl(0, 100%, 40%);">-               bind->driver->free_bind(bind);</span><br><span style="color: hsl(120, 100%, 40%);">+          gprs_ns2_free_bind(bind);</span><br><span>    return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span>@@ -678,7 +678,7 @@</span><br><span>           return CMD_ERR_NOTHING_TODO;</span><br><span> </span><br><span>     OSMO_ASSERT(bind->ll == GPRS_NS2_LL_UDP);</span><br><span style="color: hsl(0, 100%, 40%);">-    bind->driver->free_bind(bind);</span><br><span style="color: hsl(120, 100%, 40%);">+  gprs_ns2_free_bind(bind);</span><br><span>    return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span>@@ -939,7 +939,7 @@</span><br><span>           return CMD_WARNING;</span><br><span>  }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   bind->driver->free_bind(bind);</span><br><span style="color: hsl(120, 100%, 40%);">+  gprs_ns2_free_bind(bind);</span><br><span>    return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/24856">change 24856</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/24856"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0a2ad22905bcacb929b9b5f5b034af0da3081826 </div>
<div style="display:none"> Gerrit-Change-Number: 24856 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>