Change in osmo-bsc[master]: assignment_fsm: Fix null pointer dereference rx ASSIGNMENT_EV_LCHAN_E...

laforge gerrit-no-reply at lists.osmocom.org
Mon Jul 5 20:11:10 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24848 )

Change subject: assignment_fsm: Fix null pointer dereference rx ASSIGNMENT_EV_LCHAN_ERROR
......................................................................

assignment_fsm: Fix null pointer dereference rx ASSIGNMENT_EV_LCHAN_ERROR

gsm_lchan_name always expects a valid lchan pointer.

This patch fixes a crash seen:
"""
<000f> lchan_fsm.c:99 lchan(12-2-5-TCH_H-1)[0x559b880f2980]{WAIT_RLL_RTP_ESTABLISH}: (type=TCH_H) Signalling Assignment FSM of error (lchan allocation failed in state WAIT_RLL_RTP_ESTABLISH: Timeout)
Assert failed lchan ../../include/osmocom/bsc/gsm_data.h:1034
"""

Related: SYS#5392
Change-Id: I23a337d411e857954008c6f8ae60be714509d351
---
M src/osmo-bsc/assignment_fsm.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c
index f5aee82..928d3b2 100644
--- a/src/osmo-bsc/assignment_fsm.c
+++ b/src/osmo-bsc/assignment_fsm.c
@@ -935,7 +935,7 @@
 		assignment_fail(new_lchan->activate.gsm0808_error_cause,
 				"Failed to %s lchan %s",
 				conn->assignment.new_lchan ? "activate" : "modify",
-				gsm_lchan_name(conn->assignment.new_lchan));
+				conn->assignment.new_lchan ? gsm_lchan_name(conn->assignment.new_lchan) : "");
 		return;
 
 	default:

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24848
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I23a337d411e857954008c6f8ae60be714509d351
Gerrit-Change-Number: 24848
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210705/fb95d179/attachment.htm>


More information about the gerrit-log mailing list