<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24848">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">assignment_fsm: Fix null pointer dereference rx ASSIGNMENT_EV_LCHAN_ERROR<br><br>gsm_lchan_name always expects a valid lchan pointer.<br><br>This patch fixes a crash seen:<br>"""<br><000f> lchan_fsm.c:99 lchan(12-2-5-TCH_H-1)[0x559b880f2980]{WAIT_RLL_RTP_ESTABLISH}: (type=TCH_H) Signalling Assignment FSM of error (lchan allocation failed in state WAIT_RLL_RTP_ESTABLISH: Timeout)<br>Assert failed lchan ../../include/osmocom/bsc/gsm_data.h:1034<br>"""<br><br>Related: SYS#5392<br>Change-Id: I23a337d411e857954008c6f8ae60be714509d351<br>---<br>M src/osmo-bsc/assignment_fsm.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c</span><br><span>index f5aee82..928d3b2 100644</span><br><span>--- a/src/osmo-bsc/assignment_fsm.c</span><br><span>+++ b/src/osmo-bsc/assignment_fsm.c</span><br><span>@@ -935,7 +935,7 @@</span><br><span>            assignment_fail(new_lchan->activate.gsm0808_error_cause,</span><br><span>                          "Failed to %s lchan %s",</span><br><span>                           conn->assignment.new_lchan ? "activate" : "modify",</span><br><span style="color: hsl(0, 100%, 40%);">-                              gsm_lchan_name(conn->assignment.new_lchan));</span><br><span style="color: hsl(120, 100%, 40%);">+                               conn->assignment.new_lchan ? gsm_lchan_name(conn->assignment.new_lchan) : "");</span><br><span>               return;</span><br><span> </span><br><span>  default:</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/24848">change 24848</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/24848"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I23a337d411e857954008c6f8ae60be714509d351 </div>
<div style="display:none"> Gerrit-Change-Number: 24848 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>