Change in osmo-bts[master]: power_control: constrain BS power reduction on BCCH carrier

fixeria gerrit-no-reply at lists.osmocom.org
Fri Jul 2 12:38:43 UTC 2021


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24815 )

Change subject: power_control: constrain BS power reduction on BCCH carrier
......................................................................

power_control: constrain BS power reduction on BCCH carrier

BS Power Control is not allowed on the BCCH/CCCH carrier, unless
the BTS is operating in the BCCH carrier power reduction mode.

Allow constrained BS power reduction (up to 6 dB) on active logical
channels iff BCCH carrier power reduction mode is enabled.

Change-Id: I3299b6cdd230d3767321c3d6c64d468b7f5e1d02
Related: SYS#4919, SYS#4918
---
M src/common/rsl.c
1 file changed, 16 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/common/rsl.c b/src/common/rsl.c
index 5407904..010b9d3 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -1586,8 +1586,16 @@
 			return rsl_tx_chan_act_nack(lchan, RSL_ERR_SERV_OPT_UNIMPL);
 		}
 
-		lchan->bs_power_ctrl.max = BS_POWER2DB(*TLVP_VAL(&tp, RSL_IE_BS_POWER));
-		lchan->bs_power_ctrl.current = lchan->bs_power_ctrl.max;
+		uint8_t red = BS_POWER2DB(*TLVP_VAL(&tp, RSL_IE_BS_POWER));
+
+		/* BS power reduction is generally not allowed on BCCH/CCCH carrier.
+		 * However, we allow it in the BCCH carrier power reduction operation.
+		 * Constrain BS power value by the maximum reduction for this timeslot. */
+		if (ts->trx->bts->c0 == ts->trx)
+			red = OSMO_MIN(red, ts->c0_power_red_db);
+
+		lchan->bs_power_ctrl.max = red;
+		lchan->bs_power_ctrl.current = red;
 
 		LOGPLCHAN(lchan, DRSL, LOGL_DEBUG, "BS Power attenuation %u dB\n",
 			  lchan->bs_power_ctrl.current);
@@ -2210,6 +2218,12 @@
 		return 0;
 	}
 
+	/* BS power reduction is generally not allowed on BCCH/CCCH carrier.
+	 * However, we allow it in the BCCH carrier power reduction operation.
+	 * Constrain BS power value by the maximum reduction for this timeslot. */
+	if (trx->bts->c0 == trx)
+		new = OSMO_MIN(new, lchan->ts->c0_power_red_db);
+
 	/* 9.3.32 (TLV) BS Power Parameters IE (vendor specific) */
 	if ((ie = TLVP_GET(&tp, RSL_IE_BS_POWER_PARAM)) != NULL) {
 		struct gsm_power_ctrl_params *params = &lchan->bs_dpc_params;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24815
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3299b6cdd230d3767321c3d6c64d468b7f5e1d02
Gerrit-Change-Number: 24815
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210702/a76b8cc5/attachment.htm>


More information about the gerrit-log mailing list