Change in osmo-bts[master]: allow to configure multiple oml remote-ip addresses

dexter gerrit-no-reply at lists.osmocom.org
Thu Jul 1 09:05:29 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24513 )

Change subject: allow to configure multiple oml remote-ip addresses
......................................................................


Patch Set 7:

> Patch Set 7:
> 
> > Patch Set 7:
> > 
> > Just a general question (not a refactoring request): do we really need to use linux_list for storing the OML addresses in the memory? I don't think on practice anybody would need more than 2 or let's say 8 (in the most paranoid case) entries. So a simple array of pointers might be a better fit here.
> 
> I don't see what's wrong with using linuxlist here. IMHO it fits better than a static array. Let the user put as many addresses as it likes, and we don't care about quick access here.

The problem with a static array is always that you never know how much is enough. Yes one could put a pointer array with a size of 10 into the BTS struct, but then you are limited to 10 (arbitrary limit) and when the user edits the list from the VTY one would need logic to allocate/free and possibly re-order the items in that array. I am really happy with the linuxlist implementation we have, it works well for many things.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24513
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I205f68a3a7f35fee4c38a7cfba2b014237df2727
Gerrit-Change-Number: 24513
Gerrit-PatchSet: 7
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Jul 2021 09:05:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210701/5b4614cf/attachment.htm>


More information about the gerrit-log mailing list