Change in osmo-bts[master]: osmo-bts-trx: implement BCCH carrier power reduction mode

laforge gerrit-no-reply at lists.osmocom.org
Fri Jul 2 11:45:51 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24776 )

Change subject: osmo-bts-trx: implement BCCH carrier power reduction mode
......................................................................


Patch Set 7: Code-Review+2

(1 comment)

Agreeing with Vadim here.  If you want to persistently reduce the power, then you simply use max_power_red.

https://gerrit.osmocom.org/c/osmo-bts/+/24776/4/include/osmo-bts/gsm_data.h 
File include/osmo-bts/gsm_data.h:

https://gerrit.osmocom.org/c/osmo-bts/+/24776/4/include/osmo-bts/gsm_data.h@455 
PS4, Line 455: bcch_power_red_db
> My intention was to reflect the feature name here. But I agree that it may be misinterpreted. […]
yes, that works. bcch_carrier_power_red_db_ would also work. just if you remove the 'carrier' it becomes the inverse meaning.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24776
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3dcee6e910ccc61c5c63c728db9ea04327e2fc98
Gerrit-Change-Number: 24776
Gerrit-PatchSet: 7
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 02 Jul 2021 11:45:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210702/95e4bb27/attachment.htm>


More information about the gerrit-log mailing list