Change in libosmocore[master]: gsm: Fix wrong length in SI13 GPRS Cell Options IE

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Jan 29 16:55:58 UTC 2021


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/22538 )


Change subject: gsm: Fix wrong length in SI13 GPRS Cell Options IE
......................................................................

gsm: Fix wrong length in SI13 GPRS Cell Options IE

Older commit adding the 2 bits for Rel-4 extension forgot to increase
the length field (see TS 44.060 Table 12.24.1)

Fixes: 946bb95af1838fcf026587c51a6ad36e34e202c3
Change-Id: I20efb4403cdf6c5bc717502a7075630044142f17
---
M src/gsm/gsm48_rest_octets.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/38/22538/1

diff --git a/src/gsm/gsm48_rest_octets.c b/src/gsm/gsm48_rest_octets.c
index b2b37b3..f45e818 100644
--- a/src/gsm/gsm48_rest_octets.c
+++ b/src/gsm/gsm48_rest_octets.c
@@ -911,12 +911,12 @@
 		bitvec_set_bit(bv, 1);
 		if (!gco->ext_info.egprs_supported) {
 			/* 6bit length of extension */
-			bitvec_set_uint(bv, (1 + 3)-1, 6);
+			bitvec_set_uint(bv, (1 + 5)-1, 6);
 			/* EGPRS supported in the cell */
 			bitvec_set_bit(bv, 0);
 		} else {
 			/* 6bit length of extension */
-			bitvec_set_uint(bv, (1 + 5 + 3)-1, 6);
+			bitvec_set_uint(bv, (1 + 5 + 5)-1, 6);
 			/* EGPRS supported in the cell */
 			bitvec_set_bit(bv, 1);
 

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22538
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I20efb4403cdf6c5bc717502a7075630044142f17
Gerrit-Change-Number: 22538
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210129/25084f99/attachment.htm>


More information about the gerrit-log mailing list