<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22538">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm: Fix wrong length in SI13 GPRS Cell Options IE<br><br>Older commit adding the 2 bits for Rel-4 extension forgot to increase<br>the length field (see TS 44.060 Table 12.24.1)<br><br>Fixes: 946bb95af1838fcf026587c51a6ad36e34e202c3<br>Change-Id: I20efb4403cdf6c5bc717502a7075630044142f17<br>---<br>M src/gsm/gsm48_rest_octets.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/38/22538/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gsm/gsm48_rest_octets.c b/src/gsm/gsm48_rest_octets.c</span><br><span>index b2b37b3..f45e818 100644</span><br><span>--- a/src/gsm/gsm48_rest_octets.c</span><br><span>+++ b/src/gsm/gsm48_rest_octets.c</span><br><span>@@ -911,12 +911,12 @@</span><br><span>           bitvec_set_bit(bv, 1);</span><br><span>               if (!gco->ext_info.egprs_supported) {</span><br><span>                     /* 6bit length of extension */</span><br><span style="color: hsl(0, 100%, 40%);">-                  bitvec_set_uint(bv, (1 + 3)-1, 6);</span><br><span style="color: hsl(120, 100%, 40%);">+                    bitvec_set_uint(bv, (1 + 5)-1, 6);</span><br><span>                   /* EGPRS supported in the cell */</span><br><span>                    bitvec_set_bit(bv, 0);</span><br><span>               } else {</span><br><span>                     /* 6bit length of extension */</span><br><span style="color: hsl(0, 100%, 40%);">-                  bitvec_set_uint(bv, (1 + 5 + 3)-1, 6);</span><br><span style="color: hsl(120, 100%, 40%);">+                        bitvec_set_uint(bv, (1 + 5 + 5)-1, 6);</span><br><span>                       /* EGPRS supported in the cell */</span><br><span>                    bitvec_set_bit(bv, 1);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22538">change 22538</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22538"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I20efb4403cdf6c5bc717502a7075630044142f17 </div>
<div style="display:none"> Gerrit-Change-Number: 22538 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>