This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/22907 ) Change subject: ta_control: fix Timing Advance control for SDCCH channels ...................................................................... ta_control: fix Timing Advance control for SDCCH channels The check in lchan_ms_ta_ctrl() breaks Timing Advance control on SDCCH channels, because 'num_ul_meas' wraps and never reaches 4. Neither this check makes any sense for other channel types, because lchan_ms_ta_ctrl() is always called in the end of the measurement period. Let's drop it. Change-Id: I0b86d49ec00b38d0f309c56b2519e5d487f0b65b Fixes: If7ddf74db3abc9b9872abe620a0aeebe3327e70a Related: OS#5024 --- M src/common/ta_control.c 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/common/ta_control.c b/src/common/ta_control.c index 5a3cbf5..ccb60e2 100644 --- a/src/common/ta_control.c +++ b/src/common/ta_control.c @@ -33,11 +33,6 @@ { int16_t toa256 = lchan->meas.ms_toa256; - /* Do not perform any computation when the amount of measurement - * results is too little. */ - if (lchan->meas.num_ul_meas < 4) - return; - if (toa256 < -TOA256_9OPERCENT && lchan->rqd_ta > TA_MIN) { LOGPLCHAN(lchan, DLOOP, LOGL_INFO, "TOA is too early (%d), now lowering TA from %d to %d\n", -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22907 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0b86d49ec00b38d0f309c56b2519e5d487f0b65b Gerrit-Change-Number: 22907 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210222/3608c4df/attachment.htm>