<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/22907">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ta_control: fix Timing Advance control for SDCCH channels<br><br>The check in lchan_ms_ta_ctrl() breaks Timing Advance control on<br>SDCCH channels, because 'num_ul_meas' wraps and never reaches 4.<br>Neither this check makes any sense for other channel types,<br>because lchan_ms_ta_ctrl() is always called in the end of the<br>measurement period.  Let's drop it.<br><br>Change-Id: I0b86d49ec00b38d0f309c56b2519e5d487f0b65b<br>Fixes: If7ddf74db3abc9b9872abe620a0aeebe3327e70a<br>Related: OS#5024<br>---<br>M src/common/ta_control.c<br>1 file changed, 0 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/ta_control.c b/src/common/ta_control.c</span><br><span>index 5a3cbf5..ccb60e2 100644</span><br><span>--- a/src/common/ta_control.c</span><br><span>+++ b/src/common/ta_control.c</span><br><span>@@ -33,11 +33,6 @@</span><br><span> {</span><br><span>        int16_t toa256 = lchan->meas.ms_toa256;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  /* Do not perform any computation when the amount of measurement</span><br><span style="color: hsl(0, 100%, 40%);">-         * results is too little. */</span><br><span style="color: hsl(0, 100%, 40%);">-    if (lchan->meas.num_ul_meas < 4)</span><br><span style="color: hsl(0, 100%, 40%);">-          return;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>      if (toa256 < -TOA256_9OPERCENT && lchan->rqd_ta > TA_MIN) {</span><br><span>                 LOGPLCHAN(lchan, DLOOP, LOGL_INFO,</span><br><span>                     "TOA is too early (%d), now lowering TA from %d to %d\n",</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/22907">change 22907</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/22907"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0b86d49ec00b38d0f309c56b2519e5d487f0b65b </div>
<div style="display:none"> Gerrit-Change-Number: 22907 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>