This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/23008 ) Change subject: gtp-kernel: don't #include libmnl headers ...................................................................... gtp-kernel: don't #include libmnl headers * we don't check for libmnl via pkg-config in configure.ac * we don't add libmnl include path to CFLAGS As a result, we cannot #include related files. libmnl is completely encapsulated by libgtpnl. It even includes a forward-declaration of 'struct mnl_socket'. Change-Id: I0af869cc3c8e30b69d73a4985c56ef7743565e95 --- M contrib/osmo-ggsn.spec.in M lib/gtp-kernel.c 2 files changed, 0 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/osmo-ggsn.spec.in b/contrib/osmo-ggsn.spec.in index 83a1ca7..d752a8e 100644 --- a/contrib/osmo-ggsn.spec.in +++ b/contrib/osmo-ggsn.spec.in @@ -30,7 +30,6 @@ BuildRequires: systemd-rpm-macros %endif BuildRequires: pkgconfig(libgtpnl) >= 1.0.0 -BuildRequires: pkgconfig(libmnl) >= 1.0.3 BuildRequires: pkgconfig(libosmocore) >= 1.1.0 BuildRequires: pkgconfig(libosmoctrl) >= 1.1.0 BuildRequires: pkgconfig(libosmovty) >= 1.1.0 diff --git a/lib/gtp-kernel.c b/lib/gtp-kernel.c index b898ed7..2a731e6 100644 --- a/lib/gtp-kernel.c +++ b/lib/gtp-kernel.c @@ -18,7 +18,6 @@ #include <libgtpnl/gtp.h> #include <libgtpnl/gtpnl.h> -#include <libmnl/libmnl.h> #include <errno.h> -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/23008 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I0af869cc3c8e30b69d73a4985c56ef7743565e95 Gerrit-Change-Number: 23008 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210220/2771cef2/attachment.htm>