<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/23008">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gtp-kernel: don't #include libmnl headers<br><br>* we don't check for libmnl via pkg-config in configure.ac<br>* we don't add libmnl include path to CFLAGS<br><br>As a result, we cannot #include related files.<br><br>libmnl is completely encapsulated by libgtpnl.  It even<br>includes a forward-declaration of 'struct mnl_socket'.<br><br>Change-Id: I0af869cc3c8e30b69d73a4985c56ef7743565e95<br>---<br>M contrib/osmo-ggsn.spec.in<br>M lib/gtp-kernel.c<br>2 files changed, 0 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/contrib/osmo-ggsn.spec.in b/contrib/osmo-ggsn.spec.in</span><br><span>index 83a1ca7..d752a8e 100644</span><br><span>--- a/contrib/osmo-ggsn.spec.in</span><br><span>+++ b/contrib/osmo-ggsn.spec.in</span><br><span>@@ -30,7 +30,6 @@</span><br><span> BuildRequires:  systemd-rpm-macros</span><br><span> %endif</span><br><span> BuildRequires:  pkgconfig(libgtpnl) >= 1.0.0</span><br><span style="color: hsl(0, 100%, 40%);">-BuildRequires:  pkgconfig(libmnl) >= 1.0.3</span><br><span> BuildRequires:  pkgconfig(libosmocore) >= 1.1.0</span><br><span> BuildRequires:  pkgconfig(libosmoctrl) >= 1.1.0</span><br><span> BuildRequires:  pkgconfig(libosmovty) >= 1.1.0</span><br><span>diff --git a/lib/gtp-kernel.c b/lib/gtp-kernel.c</span><br><span>index b898ed7..2a731e6 100644</span><br><span>--- a/lib/gtp-kernel.c</span><br><span>+++ b/lib/gtp-kernel.c</span><br><span>@@ -18,7 +18,6 @@</span><br><span> </span><br><span> #include <libgtpnl/gtp.h></span><br><span> #include <libgtpnl/gtpnl.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <libmnl/libmnl.h></span><br><span> </span><br><span> #include <errno.h></span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/23008">change 23008</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ggsn/+/23008"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ggsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0af869cc3c8e30b69d73a4985c56ef7743565e95 </div>
<div style="display:none"> Gerrit-Change-Number: 23008 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>