This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 ) Change subject: select: gather statistics for TCP connections ...................................................................... Patch Set 9: > Maybe the timer can be disabled by default, so that no runtime overhead in terms of getsockopt is incurred. But there should be _one_ switch, provided by libosmocore, which will make all TCP sockets serving remote connections provide those statistics. To be more precise: There should be one switch, exposed to the user via the VTY, where he can enable or disable TCP statistics for all remote sockets serving signaling traffic (so we're excluding CTRL + VTY here as those are OAM and not part of the normal signaling) V8 of this patch does not introduce any overhead to osmo_select_main, all the getsockopt calls are in a timer. So from my point of view, I don't understand where your strong reaction is coming from * there is a separate list of TCP sockets. only applies to those. Adds one small dynamic allocation on socket creation time. No runtime overhead during processing of traffic of those sockets * the actual statistics polling via getsockopt happens in a timer So IMHO, there are only two topics open: 1) ensuring that the timer doesn't tage ages in case we have many TCP sockets by not polling the full list on every expiration, spreading the load over multiple timer iterations 2) thinking about setting the default timer to "off", requiring explicit user interaction to activate this feature via VTY/config -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 9 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Thu, 16 Dec 2021 11:05:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211216/d28d957f/attachment.htm>