This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 ) Change subject: select: gather statistics for TCP connections ...................................................................... Patch Set 9: > Patch Set 8: Code-Review-2 > > (1 comment) > > I'm really not happy with the proposals done so far here. I am quite happy with the second proposal, except for what I wrote in my last feedback. > Please come up with a system which only applies to specific sockets for which we really want this feature. The entire point of this patch - and I agree with this from day one of the discussion - is to have it automatically work for all TCP sockets. You are trying to change the complete premise of the patchset now retroactively. Maybe the timer can be disabled by default, so that no runtime overhead in terms of getsockopt is incurred. But there should be _one_ switch, provided by libosmocore, which will make all TCP sockets serving remote connections provide those statistics. In the end, we don't have that many TCP sockets in our typical programs anyway. Most is SCTP, unix domain or UDP. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 9 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Thu, 16 Dec 2021 10:46:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211216/4c08891d/attachment.htm>