Change in osmo-hnodeb[master]: First implementation of the LLSK audio SAPI

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502 )

Change subject: First implementation of the LLSK audio SAPI
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502/2/include/osmocom/hnodeb/hnb_prim.h 
File include/osmocom/hnodeb/hnb_prim.h:

https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502/2/include/osmocom/hnodeb/hnb_prim.h@184 
PS2, Line 184: uint8_t remote_rtp_address_type;  /* enum u_addr_type */
             : 	union u_addr remote_rtp_addr;
> ok, fair enough - but then I would try to at least have one definition local to this header file, ra […]
I wanted to avoid having them in a struct, to have a more plain structure where I can control gaps and padding manually, to avoid non-aligned accesses and so on. See in this case for instance, where a spare1 byte is kept to have the u_addr not fall in an even address. So I did this this on purpose and I'm personally fine keeping it this way.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnodeb
Gerrit-Branch: master
Gerrit-Change-Id: I9909a7c054ddaabb1bb63d7d06331cc79f642b5d
Gerrit-Change-Number: 26502
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 14 Dec 2021 14:45:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211214/9c9dc098/attachment.htm>